Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add check for the optional ref.Platform field to avoid nil pointer in TagInfoFromReferences #759

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: add check for the optional ref.Platform field to avoid nil pointer in TagInfoFromReferences #759

merged 1 commit into from
Jul 2, 2024

Conversation

chengfang
Copy link
Collaborator

Fixes #755

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.07%. Comparing base (9ad9e4f) to head (cb69423).

Files Patch % Lines
pkg/registry/client.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   56.16%   56.07%   -0.10%     
==========================================
  Files          31       31              
  Lines        3105     3110       +5     
==========================================
  Hits         1744     1744              
- Misses       1222     1227       +5     
  Partials      139      139

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jannfis
jannfis approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis changed the title add check for the optional ref.Platform field to avoid nil pointer in TagInfoFromReferences fix: add check for the optional ref.Platform field to avoid nil pointer in TagInfoFromReferences Jul 2, 2024
@jannfis jannfis merged commit d8d3b01 into argoproj-labs:master Jul 2, 2024
9 checks passed
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
@chengfang @sribiere-jellysmack
fix: add check for the optional ref.Platform field to avoid nil point…
30263e0 
…er in TagInfoFromReferences (argoproj-labs#759)

Signed-off-by: Cheng Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh pasha-codefresh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Reading tags from GitHub Container registry causes panic
3 participants
@chengfang @codecov-commenter @jannfis